Fix OSD to InventoryItem parsing - #167
Merged
cinderblocks merged 2 commits intoAug 7, 2026
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
I noticed that my call to
UpdateTaskInventory()was no longer updating the item in an object's inventory. I am finding theInventoryItemwithGetTaskInventoryAsync(), modifying it and then passing it back toUpdateTaskInventory().The issue is that
GetTaskInventoryAsync()was changed to first try and useGetTaskInventoryViaCapAsync(), which relies onInventoryItem FromOSD()to parse the deserialized llsd from theRequestTaskInventorycap.InventoryItem FromOSD()is incorrectly parsing the OSDMap that is created inGetTaskInventoryViaCapAsync():ownerIDis not getting parsed at allinvTypeandassetTypeare being read as ints, but are strings in the OSDMapSo the wrong item data is getting sent to the simulator though
UpdateTaskInventory(), and the simulator cannot update the item.Verifications
GetTaskInventoryAsync()provides a correctInventoryItemlist.