chore: VLCKit更新 - #85
Merged
Merged
Conversation
一時停止中にシークすると挙動がおかしくなる件の修正
レビュアー向けガイド(小さな PR では折りたたみ)レビュアー向けガイドVLCKit の依存関係のリビジョンを更新し、VLC プレーヤーにプリフェッチバッファサイズを調整するオプションを追加します。これは、一時停止中のシーク時に発生する異常な挙動を修正することを目的としています。 ファイルレベルの変更
紐づく Issue に対する評価
関連している可能性のある Issue
Tips とコマンドSourcery との対話
体験のカスタマイズダッシュボード にアクセスして次のことができます:
サポートを受ける
Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the VLCKit dependency revision and adds a VLC player option to adjust the prefetch buffer size, intended to fix abnormal seeking behavior while paused. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
こんにちは。変更内容を確認しましたが、とても良い出来です!
もっと役に立てるようにしたいので、各コメントに対して 👍 または 👎 をクリックしてください。そのフィードバックをもとに、今後のレビューを改善していきます。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一時停止中にシークすると挙動がおかしくなる件の修正
Fixes #82
neneka/vlckit#68
Summary by Sourcery
一時停止中のシーク動作を改善するために、VLCKit のリビジョンを更新し、プレーヤー設定を調整しました。
Enhancements:
Build:
Original summary in English
Summary by Sourcery
Update VLCKit revision and adjust player configuration to improve seek behavior while paused.
Enhancements:
Build: