wrappers for mrgali#1
Open
AntoniyaAleksandrova wants to merge 10 commits into
Open
Conversation
The setuptools module properly recognizes the install_requires directive. This allows users to properly install all requirements using `python setup.py install`
Users are advised to install pyali before using scripts in the project.
Scripts should expect pyali to be installed. Otherwise, the user should see a helpful error message if this has not been done.
Wrapper/antoniya aleksandrova
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Chris,
I've added my scripts as you've suggested. Of course, now they are not integrated in your pip package - they are just assuming the the repository is cloned somewhere in full. Please take a look and let me know if you think they should be in the package, and if so, whether it will be best to reorganize the folders.
We are submitting 2 papers that want to cite this code so it will be useful if we can finilize any changes very soon.
Thank you,
Toni