feat(PRLT-1233): interactive menu e2e tests for work start, ticket move, session attach, orchestrator + --json bypass#1256
Open
chrismcdermut wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interactive-menu.test.ts:prlt work start(ticket dropdown / source picker),prlt ticket move(ticket picker → column picker),prlt session attach(session list / empty state), andprlt orchestrator(action menu).--jsonnon-interactive bypass suite that asserts those four commands never render an inquirer menu (no ❯ indicator, no arrow-key hint) when invoked with--json.InteractiveTestSessionto expose three pure helpers (matchesPattern,isTmuxSpecialKey,shellEscape) and addstest/unit/interactive-test-session.test.tscovering them — pre-commit hook compliance and a real safety net for the harness behavior that doesn't need a live tmux server.Background — PRLT-1233
The existing tmux-driven harness (
InteractiveTestSession) andinteractive-menu.test.tswere already inmain. This PR extends the suite to cover the specific test cases the ticket calls out (interactive flows that agents in non-TTY sessions can't otherwise exercise) and adds the--jsonbypass coverage that proves the agent path stays non-interactive.Test plan
pnpm --filter @proletariat/cli test:unit— confirms 25 new harness unit tests passpnpm --filter @proletariat/cli test:e2e:interactive(in a tmux + prlt environment with seeded HQ) — confirms the new e2e cases pass and the--jsoncases assert no interactive menu renderedpnpm --filter @proletariat/cli build— typecheck🤖 Generated with Claude Code