Skip to content

feat(PRLT-1233): interactive menu e2e tests for work start, ticket move, session attach, orchestrator + --json bypass#1256

Open
chrismcdermut wants to merge 1 commit into
mainfrom
PRLT-1233/feat/e2e-test-harness-for
Open

feat(PRLT-1233): interactive menu e2e tests for work start, ticket move, session attach, orchestrator + --json bypass#1256
chrismcdermut wants to merge 1 commit into
mainfrom
PRLT-1233/feat/e2e-test-harness-for

Conversation

@chrismcdermut
Copy link
Copy Markdown
Owner

Summary

  • Adds the ticket-required interactive flows to interactive-menu.test.ts: prlt work start (ticket dropdown / source picker), prlt ticket move (ticket picker → column picker), prlt session attach (session list / empty state), and prlt orchestrator (action menu).
  • Adds a --json non-interactive bypass suite that asserts those four commands never render an inquirer menu (no ❯ indicator, no arrow-key hint) when invoked with --json.
  • Refactors InteractiveTestSession to expose three pure helpers (matchesPattern, isTmuxSpecialKey, shellEscape) and adds test/unit/interactive-test-session.test.ts covering them — pre-commit hook compliance and a real safety net for the harness behavior that doesn't need a live tmux server.

Background — PRLT-1233

The existing tmux-driven harness (InteractiveTestSession) and interactive-menu.test.ts were already in main. This PR extends the suite to cover the specific test cases the ticket calls out (interactive flows that agents in non-TTY sessions can't otherwise exercise) and adds the --json bypass coverage that proves the agent path stays non-interactive.

Test plan

  • pnpm --filter @proletariat/cli test:unit — confirms 25 new harness unit tests pass
  • pnpm --filter @proletariat/cli test:e2e:interactive (in a tmux + prlt environment with seeded HQ) — confirms the new e2e cases pass and the --json cases assert no interactive menu rendered
  • pnpm --filter @proletariat/cli build — typecheck

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant