Skip to content

fix tsan findings and compiler warnings #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d3matt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix tsan findings and compiler warnings #1761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions include/asio/detail/std_fenced_block.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,17 @@

#include "asio/detail/push_options.hpp"

#if defined(__has_feature)
# if __has_feature(thread_sanitizer)
# include "sanitizer/tsan_interface.h"
# define USE_TSAN_SEMANTICS 1
# else
# define USE_TSAN_SEMANTICS 0
# endif
#else
# define USE_TSAN_SEMANTICS 0
#endif

namespace asio {
ASIO_INLINE_NAMESPACE_BEGIN
namespace detail {
Expand All @@ -40,14 +51,27 @@ class std_fenced_block
// Constructor for a full fenced block.
explicit std_fenced_block(full_t)
{
#if USE_TSAN_SEMANTICS
__tsan_acquire(&tsan);
#else
std::atomic_thread_fence(std::memory_order_acquire);
#endif
}

// Destructor.
~std_fenced_block()
{
#if USE_TSAN_SEMANTICS
__tsan_release(&tsan);
#else
std::atomic_thread_fence(std::memory_order_release);
#endif
}

#if USE_TSAN_SEMANTICS
private:
int tsan;
#endif
};

} // namespace detail
Expand Down