Skip to content

Filter devices with writable Core Audio volume control - #6

Open
rustydomino wants to merge 2 commits into
chenjy16:mainfrom
rustydomino:fix/volume-capability-filter
Open

Filter devices with writable Core Audio volume control#6
rustydomino wants to merge 2 commits into
chenjy16:mainfrom
rustydomino:fix/volume-capability-filter

Conversation

@rustydomino

Copy link
Copy Markdown

Avoid creating SoundBridge proxies for output devices that already expose
writable Core Audio volume control.

This also improves volume capability detection by:

  • determining the actual number of output channels from the device's stream
    configuration
  • checking the main volume element and every reported output channel
  • requiring kAudioDevicePropertyVolumeScalar to be settable, rather than
    treating the mere existence of the property as usable volume control

Devices without writable Core Audio volume control continue to be accepted.

Tested with:

  • fixed-volume DisplayPort monitor: accepted
  • USB output with writable Core Audio volume: skipped
  • Host release build- Improve audio volume capability detection
  • Filter devices with writable volume control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant