test: add regression tests for frame size getters#638
Open
majiayu000 wants to merge 1 commit intocharmbracelet:mainfrom
Open
test: add regression tests for frame size getters#638majiayu000 wants to merge 1 commit intocharmbracelet:mainfrom
majiayu000 wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Cover GetHorizontalFrameSize, GetVerticalFrameSize, and GetFrameSize with table-driven sub-tests: no style, padding only, various border types, border+padding, margin, combined, partial borders, and asymmetric values. Ref charmbracelet#353 Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #353
The frame size getters (
GetHorizontalFrameSize,GetVerticalFrameSize,GetFrameSize) had a bug where they only returned padding, ignoring borderwidths. That was fixed in #411, but there were no dedicated tests for it.
This adds table-driven tests covering: