fix: Avoid background color query hang#636
Open
jedevc wants to merge 1 commit intocharmbracelet:mainfrom
Open
Conversation
Which seems to happen if stdin/stdout are somehow accidentally not TTYs. Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
force-pushed
the
fix-background-color-hang
branch
from
46dd1f1 to
7237892
Compare
| } | ||
|
|
||
| // NOTE: On Unix, one of the given files must be a tty. | ||
| if !term.IsTerminal(in.Fd()) || !term.IsTerminal(out.Fd()) { |
Member
There was a problem hiding this comment.
This would skip querying when input OR output is not a terminal, in other words, when the program expects data from input as a file or stream or the output is redirected to a file or pipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which seems to happen if stdin/stdout are somehow accidentally not TTYs.
Potential fix for #635? Might need more fixes here, but this at least seems to make things work for my use case.
CONTRIBUTING.md.