Skip to content

fix: remove incorrect start/end swap in Tree.Offset #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doganarif wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove incorrect start/end swap in Tree.Offset #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tree/testdata/TestTreeOffset/equal.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions tree/testdata/TestTreeOffset/start_greater_than_end.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tree/testdata/TestTreeOffset/zero.golden
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions tree/tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,6 @@ func (t *Tree) SetHidden(hidden bool) { t.Hide(hidden) }

// Offset sets the Tree children offsets.
func (t *Tree) Offset(start, end int) *Tree {
if start > end {
_start := start
start = end
end = _start
}

if start < 0 {
start = 0
}
Expand Down
24 changes: 24 additions & 0 deletions tree/tree_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,30 @@ func TestAt(t *testing.T) {
}
}

func TestTreeOffset(t *testing.T) {
tr := tree.New().
Root("Root").
Child("A", "B", "C", "D", "E")

t.Run("start_greater_than_end", func(t *testing.T) {
// Offset(2,1) should skip 2 from start, 1 from end.
o := tree.New().Root("Root").Child("A", "B", "C", "D", "E")
o.Offset(2, 1)
golden.RequireEqual(t, []byte(o.String()))
})

t.Run("equal", func(t *testing.T) {
o := tree.New().Root("Root").Child("A", "B", "C", "D", "E")
o.Offset(1, 1)
golden.RequireEqual(t, []byte(o.String()))
})

t.Run("zero", func(t *testing.T) {
tr.Offset(0, 0)
golden.RequireEqual(t, []byte(tr.String()))
})
}

func TestFilter(t *testing.T) {
data := tree.NewFilter(tree.NewStringData(
"Foo",
Expand Down