You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This revision renames Complete to CompleteColor and CompleteFunc to CompleteColorFunc. Out of context, Complete is too ambiguous, particularly because the scope of Lip Gloss is beyond color.
@aymanbagabas I thinkLightDark is fine as-is because it implies color (or, at least, luminance). I'm fine if Complete is something other than CompleteColor but we need something beyond Complete to make it more specific.
CompleteColor to me still doesn't convey the full purpose/intent, only helping convey that it's related to a color. Thoughts on something like ResolveColor (ColorResolverFunc for the func type)? "resolve" indicates it is the final result of some computed logic, and that might hint that a user can hook into that resolution logic to change it.
Some other thoughts, in case we're still not 100% on anything:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision renames
CompletetoCompleteColorandCompleteFunctoCompleteColorFunc. Out of context,Completeis too ambiguous, particularly because the scope of Lip Gloss is beyond color.