Fix border width calculation in renderHorizontalEdge#559
Open
akaoio wants to merge 1 commit intocharmbracelet:masterfrom
Open
Fix border width calculation in renderHorizontalEdge#559akaoio wants to merge 1 commit intocharmbracelet:masterfrom
akaoio wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
The renderHorizontalEdge function had an off-by-one error that caused borders to be rendered with incorrect width. This fix: 1. Properly calculates the middle section width by subtracting both left and right widths from the total width 2. Fixes the loop logic to fill exactly the required middle width 3. Adds comprehensive tests to verify correct border rendering This resolves issues where borders would overflow or underflow their intended width, particularly noticeable with wider borders. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
Thanks for this. In order for us to verify the issue, can you put together some sample code to verify the issue exists? This will greatly help us expedite our ability to review the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderHorizontalEdgethat caused borders to render with incorrect widthProblem
The
renderHorizontalEdgefunction had a bug where:This was particularly noticeable with wider borders or specific width values.
Solution
width - leftWidth - rightWidthapplyBorderTest Plan
✅ Added
TestRenderHorizontalEdgeFixwith multiple test cases✅ All existing tests pass
✅ Verified borders render at exact specified widths
🤖 Generated with Claude Code