feat!(borders): add ability apply left/right borders only#360
Draft
meowgorithm wants to merge 5 commits intomasterfrom
Draft
feat!(borders): add ability apply left/right borders only#360meowgorithm wants to merge 5 commits intomasterfrom
meowgorithm wants to merge 5 commits intomasterfrom
Conversation
Previously, inline mode would obliterate borders altogether. This changes the way the render works slighly, but for all intents and purposes the impact should be little to none.
In other words, when determining which sides need borders, don't factor in the middle section that was added to support tables.
If the top and bottom borders are missing the left and right borders will now render. If the text value rendered is one line, this will essentially work akin to inline mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Horizontal Borders Only
This set of revision fixes some quirks with the border algorithm allowing you to set left and right borders only using various logical techniques:
This changes the way the render works slighly, but for all intents and
purposes the impact should be little to none.
Also included are a series of border tests.