Skip to content

fix: removed string concat in a loop is inefficient warning #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corbinlazarone wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

fix: removed string concat in a loop is inefficient warning #1633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tutorials/basics/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"fmt"
"os"
"strings"

tea "charm.land/bubbletea/v2"
)
Expand Down Expand Up @@ -57,6 +58,7 @@ func (m model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
}

func (m model) View() tea.View {
var sb strings.Builder
s := "What should we buy at the market?\n\n"

for i, choice := range m.choices {
Expand All @@ -70,9 +72,10 @@ func (m model) View() tea.View {
checked = "x"
}

s += fmt.Sprintf("%s [%s] %s\n", cursor, checked, choice)
fmt.Fprintf(&sb, "%s [%s] %s\n", cursor, checked, choice)
}

s += sb.String()
s += "\nPress q to quit.\n"

v := tea.NewView(s)
Expand Down