Skip to content

add ceph-osd-crimson to noble builds for main/feature branches #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shraddhaag wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add ceph-osd-crimson to noble builds for main/feature branches #2592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ceph-dev-pipeline/build/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ pipeline {
values 'default', 'debug'
}
}
// debug flavor is currently only supported on centos9 and rocky10, x86_64
// debug flavor is currently only supported on centos9, rocky10 and noble, x86_64
excludes {
exclude {
axis {
Expand All @@ -210,7 +210,7 @@ pipeline {
}
axis {
name 'DIST'
notValues 'centos9', 'rocky10'
notValues 'centos9', 'rocky10', 'noble'
Copy link
Copy Markdown
Contributor

@Matan-B Matan-B May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, this is should be a seperate commit as it adds debug builds to noble (not related to the crimson change)

}
}
exclude {
Expand Down Expand Up @@ -470,6 +470,13 @@ pipeline {
if ( env.SCCACHE == "true" && ! ceph_extra_cmake_args.contains(sccache_flag) ) {
ceph_extra_cmake_args += " ${sccache_flag}"
}
// Build the ceph-osd-crimson package on noble for main/feature
// branches only (release lines reef/squid/tentacle excluded),
// matching the WITH_CRIMSON gate used for the builder image.
def withCrimson = !(env.BRANCH in ['tentacle', 'squid', 'reef'])
Copy link
Copy Markdown
Contributor

@Matan-B Matan-B May 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the correct place to enable Crimson builds. This will result in every Noble/main build to be with Crimson. If that's the intent we would need to first verify that we are not breaking Noble builds for non-crimson usage.

In the past we had the dedicated flavor freedom to make such changes. Today, I think that the two options to verify a new distro would be:

if ( withCrimson && env.DIST == "noble" ) {
deb_build_profiles = deb_build_profiles ? "${deb_build_profiles} pkg.ceph.crimson" : "pkg.ceph.crimson"
Copy link
Copy Markdown
Contributor

@Matan-B Matan-B May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is out of Jenkins responsibility.
See how Crimson is enabled in rpm builds - ceph/ceph@08c334b.

Debian should follow the same logic once we are able to verify green builds (See debian/ceph-osd-crimson.postinst)

}
if ( deb_build_profiles ) {
sh """#!/bin/bash
echo "DEB_BUILD_PROFILES=${deb_build_profiles}" >> .env
Expand Down