Skip to content

ceph-perf: tighten PR regression gate#2566

Open
knrt10 wants to merge 1 commit into
mainfrom
reenable-ceph-perf-check
Open

ceph-perf: tighten PR regression gate#2566
knrt10 wants to merge 1 commit into
mainfrom
reenable-ceph-perf-check

Conversation

@knrt10
Copy link
Copy Markdown
Member

@knrt10 knrt10 commented Apr 7, 2026

This describes the perf PR job as a release regression check, pin the benchmark definition to ceph-main, and surface the perf regression status in GitHub. This also reenables the ceph-perf-pull-request

Fixes: https://tracker.ceph.com/issues/75665

Copilot AI review requested due to automatic review settings April 7, 2026 05:33
@knrt10 knrt10 force-pushed the reenable-ceph-perf-check branch from 25b9570 to 18e33c0 Compare April 7, 2026 05:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ceph-perf pull request performance job to behave as a stricter release-style regression gate by pinning the benchmark definition to ceph-main and surfacing regression status directly on GitHub PRs.

Changes:

  • Parameterize CBT workload selection in the run-cbt macro and pin the benchmark YAML to ceph-main.
  • Add/refresh GitHub PR status context strings to make perf regression results visible in the PR UI.
  • Re-enable the perf PR job template (disabled: false) and clarify the job’s purpose via description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
@knrt10 knrt10 force-pushed the reenable-ceph-perf-check branch from 18e33c0 to c517923 Compare April 7, 2026 05:42
Copy link
Copy Markdown
Contributor

@Matan-B Matan-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few pieces still missing here. I’m not sure this would work with older compilers and exiting CBT support. I would suggest trying to run some of the tests locally first to see if the numbers make sense before we start blocking PRs with this job.
Is this check required once enabled?

We should probably also add some details to Crimson’s dev guide, how the test works, when a PR is blocked (under which cases) and where the results are stored. This should help devs mitigate failures.

Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
@Matan-B Matan-B added this to Crimson Apr 7, 2026
@Matan-B Matan-B moved this to In Progress in Crimson Apr 7, 2026
@Matan-B Matan-B requested a review from perezjosibm April 7, 2026 09:51
@knrt10 knrt10 force-pushed the reenable-ceph-perf-check branch from c517923 to 7359ce6 Compare April 8, 2026 06:06
Copy link
Copy Markdown
Contributor

@Matan-B Matan-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand if this is ready for review or was tested locally.
If it was, can you please share examples of how the results comparison work?

The clang version that was already mentioned in the previous review would still FTBFS.
CBT is still not updated for the relevant usage with Crimson.
Under which cases a PR is considered blocked (dev docs)?
It is also not clear what the strategy is here - is this intended to run only against Crimson PRs?

Please make sure there is a solid plan for how this is going to be implemented. Starting with a draft PR is also a good approach, but please be clear about the draft stage (what is missing, what is not yet tested/verified and what the next steps are or what is working so far). Otherwise, this PR does not seem ready for review.

My suggestion here would be to enable this check as a non-required PR check and iterate on it until it can be re-enabled as a required one. Alternatively, running parts of the jobs locally to make sure all is working as expected.
I would be happy to help in any way if you have any questions.

Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
@knrt10 knrt10 marked this pull request as draft April 13, 2026 13:22
@knrt10 knrt10 force-pushed the reenable-ceph-perf-check branch 2 times, most recently from 94866b0 to 064d528 Compare April 14, 2026 00:11
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
Comment thread ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml Outdated
@knrt10 knrt10 force-pushed the reenable-ceph-perf-check branch from 064d528 to 007d18b Compare May 26, 2026 09:49
@knrt10 knrt10 marked this pull request as ready for review May 26, 2026 09:49
@knrt10 knrt10 requested review from Matan-B and tchaikov May 26, 2026 09:49
@knrt10 knrt10 force-pushed the reenable-ceph-perf-check branch 3 times, most recently from f2cd7b4 to 76ddf37 Compare May 26, 2026 11:54
This describes the perf PR job as a release regression check, pin the
benchmark definition to ceph-main, and surface the perf regression
status in GitHub. This also reenables the ceph-perf-pull-request

Fixes: https://tracker.ceph.com/issues/75665
Signed-off-by: Kautilya Tripathi <kautilya.tripathi@ibm.com>
@knrt10 knrt10 force-pushed the reenable-ceph-perf-check branch from 76ddf37 to 9103af4 Compare May 26, 2026 12:56
@Matan-B Matan-B moved this from In Progress to Awaits review in Crimson May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaits review

Development

Successfully merging this pull request may close these issues.

4 participants