enh(network::paloalto::api) Add host discovery to handle Panorama#6188
Draft
scresto31 wants to merge 11 commits into
Draft
enh(network::paloalto::api) Add host discovery to handle Panorama#6188scresto31 wants to merge 11 commits into
scresto31 wants to merge 11 commits into
Conversation
scresto31
requested review from
bouda1,
lucie-tirand and
sechkem
and removed request for
a team
omercier
reviewed
May 19, 2026
omercier
reviewed
May 28, 2026
…-host-discovery-to-handle-panorama
…-host-discovery-to-handle-panorama
omercier
reviewed
Jun 2, 2026
Comment on lines
+125
to
+126
| next if is_excluded($serial, $self->{option_results}->{include_device_serial}, $self->{option_results}->{exclude_device_serial}, output => $self->{output}) || | ||
| is_excluded($hostname, $self->{option_results}->{include_device_hostname}, $self->{option_results}->{exclude_device_hostname}, output => $self->{output}); |
Contributor
There was a problem hiding this comment.
Suggested change
| next if is_excluded($serial, $self->{option_results}->{include_device_serial}, $self->{option_results}->{exclude_device_serial}, output => $self->{output}) || | |
| is_excluded($hostname, $self->{option_results}->{include_device_hostname}, $self->{option_results}->{exclude_device_hostname}, output => $self->{output}); | |
| next if is_excluded($serial, $self->{option_results}->{include_device_serial}, $self->{option_results}->{exclude_device_serial}, output => $self->{output}) | |
| || is_excluded($hostname, $self->{option_results}->{include_device_hostname}, $self->{option_results}->{exclude_device_hostname}, output => $self->{output}); |
| next if is_excluded($name, $self->{option_results}->{include_tunnel_name}, $self->{option_results}->{exclude_tunnel_name}); | ||
| next if is_excluded($gateway, $self->{option_results}->{include_gateway_name}, $self->{option_results}->{exclude_gateway_name}); | ||
| next if is_excluded($name, $self->{option_results}->{include_tunnel_name}, $self->{option_results}->{exclude_tunnel_name}, output => $self->{output}) || | ||
| is_excluded($gateway, $self->{option_results}->{include_gateway_name}, $self->{option_results}->{exclude_gateway_name}, output => $self->{output}); |
Contributor
There was a problem hiding this comment.
Suggested change
| is_excluded($gateway, $self->{option_results}->{include_gateway_name}, $self->{option_results}->{exclude_gateway_name}, output => $self->{output}); | |
| next if is_excluded($name, $self->{option_results}->{include_tunnel_name}, $self->{option_results}->{exclude_tunnel_name}, output => $self->{output}) | |
| || is_excluded($gateway, $self->{option_results}->{include_gateway_name}, $self->{option_results}->{exclude_gateway_name}, output => $self->{output}); |
Contributor
Author
|
I'm moving this PR back to draft until I can validate it on a real environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Plugin(network-paloalto-api): add host discovery to handle Panorama
Fixes # CTOR-2278
Type of change