Skip to content

Plugin(hardware::ups::phoenixtec::snmp) : remove thresholds for not existing counters in --help #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmorandell-pgum wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Plugin(hardware::ups::phoenixtec::snmp) : remove thresholds for not existing counters in --help #6142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 60 additions & 40 deletions src/centreon/common/xppc/snmp/mode/outputlines.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright 2024 Centreon (http://www.centreon.com/)
# Copyright 2026 Centreon (http://www.centreon.com/)
#
# Centreon is a full-fledged industry-strength solution that meets
# the needs in IT infrastructure and application monitoring for
Expand All @@ -25,6 +25,7 @@ use base qw(centreon::plugins::templates::counter);
use strict;
use warnings;
use centreon::plugins::templates::catalog_functions qw(catalog_status_threshold_ng);
use centreon::plugins::constants qw(:counters :values);

sub custom_status_output {
my ($self, %options) = @_;
Expand All @@ -40,48 +41,53 @@ sub prefix_global_output {

sub set_counters {
my ($self, %options) = @_;

$self->{maps_counters_type} = [
{ name => 'global', type => 0, cb_prefix_output => 'prefix_global_output', skipped_code => { -10 => 1 } }
{
name => 'global',
type => COUNTER_TYPE_GLOBAL,
cb_prefix_output => 'prefix_global_output',
skipped_code => { NO_VALUE() => 1 }
}
];

$self->{maps_counters}->{global} = [
{
label => 'status',
type => 2,
unknown_default => '%{status} =~ /unknown/i',
warning_default => '%{status} =~ /rebooting|onBypass/i',
label => 'status',
type => 2,
unknown_default => '%{status} =~ /unknown/i',
warning_default => '%{status} =~ /rebooting|onBypass/i',
critical_default => '%{status} =~ /onBattery/i',
set => {
key_values => [ { name => 'status' } ],
closure_custom_output => $self->can('custom_status_output'),
closure_custom_perfdata => sub { return 0; },
set => {
key_values => [ { name => 'status' } ],
closure_custom_output => $self->can('custom_status_output'),
closure_custom_perfdata => sub {return 0;},
closure_custom_threshold_check => \&catalog_status_threshold_ng
}
},
{ label => 'load', nlabel => 'lines.output.load.percentage', set => {
key_values => [ { name => 'upsSmartOutputLoad', no_value => -1 } ],
output_template => 'load: %.2f %%',
perfdatas => [
{ template => '%.2f', min => 0, max => 100 }
]
}
key_values => [ { name => 'upsSmartOutputLoad', no_value => -1 } ],
output_template => 'load: %.2f %%',
perfdatas => [
{ template => '%.2f', min => 0, max => 100 }
]
}
},
{ label => 'frequence', nlabel => 'lines.output.frequence.hertz', set => {
key_values => [ { name => 'upsSmartOutputFrequency', no_value => 0 } ],
output_template => 'frequence: %.2f Hz',
perfdatas => [
{ template => '%.2f', unit => 'Hz' }
]
}
key_values => [ { name => 'upsSmartOutputFrequency', no_value => 0 } ],
output_template => 'frequence: %.2f Hz',
perfdatas => [
{ template => '%.2f', unit => 'Hz' }
]
}
},
{ label => 'voltage', nlabel => 'lines.output.voltage.volt', set => {
key_values => [ { name => 'upsSmartOutputVoltage', no_value => 0 } ],
output_template => 'voltage: %s V',
perfdatas => [
{ template => '%s', unit => 'V' }
]
}
key_values => [ { name => 'upsSmartOutputVoltage', no_value => 0 } ],
output_template => 'voltage: %s V',
perfdatas => [
{ template => '%s', unit => 'V' }
]
}
}
];
}
Expand All @@ -91,8 +97,7 @@ sub new {
my $self = $class->SUPER::new(package => __PACKAGE__, %options, force_new_perfdata => 1);
bless $self, $class;

$options{options}->add_options(arguments => {
});
$options{options}->add_options(arguments => {});

return $self;
}
Expand All @@ -107,22 +112,26 @@ my $map_status = {

my $mapping = {
upsBaseOutputStatus => { oid => '.1.3.6.1.4.1.935.1.1.1.4.1.1', map => $map_status },
upsSmartOutputVoltage => { oid => '.1.3.6.1.4.1.935.1.1.1.4.2.1' }, # in dV
upsSmartOutputFrequency => { oid => '.1.3.6.1.4.1.935.1.1.1.4.2.2' }, # in tenth of Hz
upsSmartOutputLoad => { oid => '.1.3.6.1.4.1.935.1.1.1.4.2.3' } # in %
upsSmartOutputVoltage => { oid => '.1.3.6.1.4.1.935.1.1.1.4.2.1' },# in dV
upsSmartOutputFrequency => { oid => '.1.3.6.1.4.1.935.1.1.1.4.2.2' },# in tenth of Hz
upsSmartOutputLoad => { oid => '.1.3.6.1.4.1.935.1.1.1.4.2.3' }# in %
};

sub manage_selection {
my ($self, %options) = @_;

my $snmp_result = $options{snmp}->get_leef(
oids => [ map($_->{oid} . '.0', values(%$mapping)) ],
oids => [ map($_->{oid} . '.0', values(%$mapping)) ],
nothing_quit => 1
);

my $result = $options{snmp}->map_instance(mapping => $mapping, results => $snmp_result, instance => '0');
$result->{upsSmartOutputFrequency} = defined($result->{upsSmartOutputFrequency}) ? $result->{upsSmartOutputFrequency} * 0.1 : 0;
$result->{upsSmartOutputVoltage} = defined($result->{upsSmartOutputVoltage}) ? $result->{upsSmartOutputVoltage} * 0.1 : 0;
$result->{upsSmartOutputFrequency} = defined($result->{upsSmartOutputFrequency}) ?
$result->{upsSmartOutputFrequency} * 0.1 :
0;
$result->{upsSmartOutputVoltage} = defined($result->{upsSmartOutputVoltage}) ?
$result->{upsSmartOutputVoltage} * 0.1 :
0;
$result->{status} = $result->{upsBaseOutputStatus};

$self->{global} = $result;
Expand Down Expand Up @@ -152,10 +161,21 @@ You can use the following variables: %{status}.
Define the conditions to match for the status to be CRITICAL (default: '%{status} =~ /onBattery/i').
You can use the following variables: %{status}.

=item B<--warning-*> B<--critical-*>
=item B<--warning-load>

Threshold.

=item B<--critical-load>

Threshold.

=item B<--warning-voltage>

Threshold.

=item B<--critical-voltage>

Thresholds.
Can be: 'load', 'voltage', 'current', 'power'.
Threshold.

=back

Expand Down