feat(fault-proof): make proposer tx confirmation timeout configurable#137
Merged
Conversation
The signer's hardcoded TIMEOUT_SECONDS=60 is too tight for 3 L1 confirmations on Ethereum mainnet (~36s of pure block time leaves only ~24s for mempool inclusion). Under any congestion the watcher gives up while the tx is still in flight, returns an error, and the proposer immediately retries - racing the original tx and producing duplicate sibling games when the original eventually lands. Add `tx_confirmation_timeout` (env: TX_CONFIRMATION_TIMEOUT) to ProposerConfig with a default of 180s, plumb a new `send_transaction_request_with_timeout` through the signer, and use it for all four proposer L1 tx paths (creation, proving, resolution, bond claim). Challenger and validity proposer continue to use the existing 60s default via the unchanged `send_transaction_request` wrapper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
seolaoh
force-pushed
the
seolaoh/increase-timeout
branch
from
4c074b7 to
6899941
Compare
palango
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signer's hardcoded
TIMEOUT_SECONDS=60is too tight for 3 L1 confirmations on Ethereum mainnet (~36s of pure block time leaves only ~24s for mempool inclusion). Under any congestion the watcher gives up while the tx is still in flight, returns an error, and the proposer immediately retries - racing the original tx and producing duplicate sibling games when the original eventually lands.To prevent this, add
tx_confirmation_timeout(env:TX_CONFIRMATION_TIMEOUT) toProposerConfigwith a default of 180s, plumb a newsend_transaction_request_with_timeoutthrough the signer, and use it for all four proposer L1 tx paths (creation, proving, resolution, bond claim). Challenger and validity proposer continue to use the existing 60s default via the unchangedsend_transaction_requestwrapper.Upstream PR is also opened, but want to merge it until the upstream changes are pulled in.