feat(gcpubsub): update existing subscriptions on config changes#2532
Merged
auvipy merged 2 commits intoApr 29, 2026
Merged
Conversation
When a subscription already exists, update it with the current configuration instead of silently ignoring the AlreadyExists exception. This allows workers to automatically sync subscription settings (ack_deadline_seconds, expiration_policy, message_retention_duration, enable_exactly_once_delivery, filters) without manual intervention in the GCP Console. Squashed rebase of celery#2445 (originally authored by ranjith nagaraj <rnagaraj13@users.noreply.github.com>) onto current main, with conflict resolution to preserve enable_exactly_once_delivery in both the create payload and the update mask. Fixes celery#2444
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2532 +/- ##
==========================================
+ Coverage 82.50% 82.52% +0.02%
==========================================
Files 79 79
Lines 10197 10209 +12
Branches 1171 1172 +1
==========================================
+ Hits 8413 8425 +12
Misses 1582 1582
Partials 202 202 ☔ View full report in Codecov by Sentry. |
Member
|
the integration test failures are not related to this PR |
…bscription-exists
auvipy
approved these changes
Apr 29, 2026
serl
deleted the
gcppubsub-update-subscription-config-when-subscription-exists
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subscription already exists, update it with the current configuration instead of silently ignoring the AlreadyExists exception. This allows workers to automatically sync subscription settings (ack_deadline_seconds, expiration_policy, message_retention_duration, enable_exactly_once_delivery, filters) without manual intervention in the GCP Console.
Squashed rebase of #2445 (originally authored by ranjith nagaraj rnagaraj13@users.noreply.github.com) onto current main, with conflict resolution to preserve enable_exactly_once_delivery in both the create payload and the update mask.
Fixes #2444 #2445