Sim-vs-obs plots for the 3 BU SIPNET ensembles (#238)#31
Conversation
AritraDey-Dev
force-pushed
the
cal-val-plots-238
branch
from
7816e40 to
f58370b
Compare
AritraDey-Dev
force-pushed
the
cal-val-plots-238
branch
from
f58370b to
ce2a791
Compare
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Signed-off-by: Aritra Dey <adey01027@gmail.com>
AritraDey-Dev
force-pushed
the
cal-val-plots-238
branch
from
ce2a791 to
3749a56
Compare
divine7022
left a comment
divine7022
left a comment
There was a problem hiding this comment.
thanks for plots, highlevel
not totally sure on where it belongs at this moment but for sure not workflows.
for now i would suggest have this under benckmarking/ dir or similar in uncertainity repo
droped some inline, nice to have a look
| # ---------------------------------------------------------------------------- | ||
| WORKBOOK_DIR <- Sys.getenv( | ||
| "WORKBOOK_DIR", | ||
| unset = "/projectnb2/dietzelab/ccmmf/usr/adey2/workflows" |
There was a problem hiding this comment.
small thing, nothing blocking. right now WORKBOOK_DIR points at your scc folder and the script grabs the raw xlsx straight from there
i just got cal-val-data repo stood up where the cleaned cal/val data lives as csv. once that settles it would be nicer to read from those csvs instead of the workbook so anybody can run this. so no need to touch anything now, just leaving a note so we circle back and hook it up later
| # Read a single PEcAn-style NetCDF (one year file) and return a tibble with | ||
| # posix + the requested variable. Time is encoded in the standard CF way | ||
| # (units = "days since YYYY-01-01" or similar). | ||
| read_one_nc <- function(nc_path, variable) { |
There was a problem hiding this comment.
read_one_nc is hand rolling the netcdf read here and parsing cf time units by chopping the string apart.
any reason not to lean on read.output/ ncdf4 helpers we already have for pulling the time origin and doing the unit conversion ? feels like a lot less to get wrong than re rolling it ourselves
There was a problem hiding this comment.
these plot pngs are checked into the repo, and since they get regenerated they will keep churning in the diffs and go stale fast. might be cleaner drop the plots folder and just let folks rebuild them from the script, that way repo only carries code and not the output
this totally fine now, in intent to get it documented of records is more priority
2 participants
Sim-vs-obs plots for the 3 BU SIPNET ensembles (Salinas SOCS, Modesto Nichols, Russell Ranch).
Closes ccmmf/organization#238.
Salinas SOCS — TotSoilCarb
Modesto Nichols — N₂O flux
Russell Ranch — TotSoilCarb (derived)