Skip to content

Enable DetectionWithSubRuleTest and report dependent rule findings #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somiljain2006 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −16
Open

Enable DetectionWithSubRuleTest and report dependent rule findings #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions java/src/test/files/rules/detection/DetectionWithSubRuleTestFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import javax.crypto.Cipher;
import javax.crypto.spec.SecretKeySpec;
import java.security.InvalidKeyException;

public class DetectionWithSubRuleTestFile {

void test(Cipher cipher) throws InvalidKeyException {
cipher.init(Cipher.DECRYPT_MODE, new SecretKeySpec("0123456789ABCDEF".getBytes(), "AES")); // Noncompliant {{2}}
void test() throws Exception {
Cipher cipher = Cipher.getInstance("AES"); // Noncompliant {{AES}}
cipher.init(Cipher.DECRYPT_MODE, new SecretKeySpec("0123456789ABCDEF".getBytes(), "AES")); // Noncompliant {{128}} {{2}} {{AES}}
}
}
26 changes: 13 additions & 13 deletions java/src/test/java/com/ibm/plugin/rules/detection/DetectionWithSubRuleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,11 @@

import com.ibm.engine.detection.DetectionStore;
import com.ibm.engine.detection.Finding;
import com.ibm.engine.utils.DetectionStoreLogger;
import com.ibm.mapper.model.INode;
import com.ibm.plugin.TestBase;
import com.ibm.plugin.rules.detection.jca.cipher.JcaCipherGetInstance;
import java.util.List;
import javax.annotation.Nonnull;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.sonar.check.Rule;
import org.sonar.java.checks.verifier.CheckVerifier;
Expand All @@ -51,7 +49,6 @@ public void asserts(
// nothing
}

@Disabled("")
@Test
void test() {
CheckVerifier.newVerifier()
Expand All @@ -62,15 +59,18 @@ void test() {

@Override
public void update(@Nonnull Finding<JavaCheck, Tree, Symbol, JavaFileScannerContext> finding) {
final DetectionStore<JavaCheck, Tree, Symbol, JavaFileScannerContext> detectionStore =
finding.detectionStore();
(new DetectionStoreLogger<JavaCheck, Tree, Symbol, JavaFileScannerContext>())
.print(detectionStore);
detectionStore
.getDetectionValues()
.forEach(
iValue -> {
this.reportIssue(iValue.getLocation(), iValue.asString());
});
reportStore(finding.detectionStore());
}

private void reportStore(
DetectionStore<JavaCheck, Tree, Symbol, JavaFileScannerContext> store) {
if (store == null) {
return;
}

store.getDetectionValues()
.forEach(value -> this.reportIssue(value.getLocation(), value.asString()));

store.getChildren().forEach(this::reportStore);
}
}