fix: check melt status in ws notification receiver#2135
Open
asmogo wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2135 +/- ##
==========================================
+ Coverage 71.60% 71.82% +0.22%
==========================================
Files 356 356
Lines 74106 74355 +249
==========================================
+ Hits 53061 53408 +347
+ Misses 21045 20947 -98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This fixes the 'melting from nutshell' issues that I witnessed a couple of days ago. |
Collaborator
Author
|
I'll add some more tests soon. |
The status-recheck logic in PendingMelt::wait (commit b7a12f4) had 0% patch coverage. Extract the non-Paid reconciliation block into a testable helper reconcile_non_paid_status (behavior-preserving) and add unit tests for every branch: - HTTP Paid -> finalize - HTTP Pending/Unknown -> keep waiting - HTTP Unpaid/Failed without proof -> fail - HTTP Failed with proof -> keep waiting (avoid proof loss) - HTTP status-check error -> run recovery Adds MockMintConnector::push_melt_quote_status_response for staging a sequence of status responses and create_test_wallet_with_mock_http_subscription to drive subscription flows over HTTP deterministically. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)