fix(cdk-axum): require swap auth before serving cached responses#2109
Open
prusnak wants to merge 1 commit into
Open
fix(cdk-axum): require swap auth before serving cached responses#2109prusnak wants to merge 1 commit into
prusnak wants to merge 1 commit into
Conversation
Move `/v1/swap` auth verification ahead of the NUT-19 cache lookup. The generated cache wrapper for `post_swap` calculated the cache key and returned cached `SwapResponse` values before calling the wrapped handler. Since `post_swap` performed `verify_auth` internally, a caller who replayed an identical cached swap body could receive the cached response without presenting or consuming auth on protected swap routes. Replace the generated swap cache wrapper with a swap-specific implementation that verifies route auth first, then checks the cache. On cache misses, the wrapper processes the swap and stores the response as before. The swap path is split into small helpers so auth is not checked twice on misses and blind auth tokens are consumed exactly once per request. Add a regression test that preloads a cached swap response for a clear-auth protected swap route and verifies an unauthenticated request is rejected before the cached response can be returned.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
+ Coverage 71.36% 71.41% +0.04%
==========================================
Files 356 356
Lines 73660 73713 +53
==========================================
+ Hits 52569 52643 +74
+ Misses 21091 21070 -21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
/v1/swapauth verification ahead of the NUT-19 cache lookup.The generated cache wrapper for
post_swapcalculated the cache key and returned cachedSwapResponsevalues before calling the wrapped handler. Sincepost_swapperformedverify_authinternally, a caller who replayed an identical cached swap body could receive the cached response without presenting or consuming auth on protected swap routes.Replace the generated swap cache wrapper with a swap-specific implementation that verifies route auth first, then checks the cache. On cache misses, the wrapper processes the swap and stores the response as before. The swap path is split into small helpers so auth is not checked twice on misses and blind auth tokens are consumed exactly once per request.
Add a regression test that preloads a cached swap response for a clear-auth protected swap route and verifies an unauthenticated request is rejected before the cached response can be returned.