feat: reduce ci job count#2104
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c94ec1d0db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Run quick-check | ||
| run: nix develop -i -L .#stable --command just quick-check | ||
| - name: Run workspace clippy | ||
| run: nix develop -i -L .#stable --command cargo clippy --workspace --all-targets -- -D warnings |
There was a problem hiding this comment.
Restore unit test execution in quick-check
This now only runs clippy. I checked the rest of this workflow and the flake-discovered check matrix: no remaining job runs the removed just quick-check/test-units workspace unit suite, and crates such as cdk-bdk and cdk-http-client are not included in clippyAndTestChecks, so their existing unit tests would no longer execute in CI. Please keep the unit-test portion here or add those crates to the Nix test matrix before dropping just quick-check.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
==========================================
- Coverage 71.60% 71.60% -0.01%
==========================================
Files 356 356
Lines 74106 74106
==========================================
- Hits 53065 53063 -2
- Misses 21041 21043 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c94ec1d to
57cc6ed
Compare
57cc6ed to
3543401
Compare
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)