Skip to content

feat: reduce ci job count#2104

Open
thesimplekid wants to merge 1 commit into
cashubtc:mainfrom
thesimplekid:reduce_ci_count
Open

feat: reduce ci job count#2104
thesimplekid wants to merge 1 commit into
cashubtc:mainfrom
thesimplekid:reduce_ci_count

Conversation

@thesimplekid

Copy link
Copy Markdown
Collaborator

Description


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@github-project-automation github-project-automation Bot moved this to Backlog in CDK Jun 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c94ec1d0db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
- name: Run quick-check
run: nix develop -i -L .#stable --command just quick-check
- name: Run workspace clippy
run: nix develop -i -L .#stable --command cargo clippy --workspace --all-targets -- -D warnings

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore unit test execution in quick-check

This now only runs clippy. I checked the rest of this workflow and the flake-discovered check matrix: no remaining job runs the removed just quick-check/test-units workspace unit suite, and crates such as cdk-bdk and cdk-http-client are not included in clippyAndTestChecks, so their existing unit tests would no longer execute in CI. Please keep the unit-test portion here or add those crates to the Nix test matrix before dropping just quick-check.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.60%. Comparing base (feaf823) to head (3543401).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2104      +/-   ##
==========================================
- Coverage   71.60%   71.60%   -0.01%     
==========================================
  Files         356      356              
  Lines       74106    74106              
==========================================
- Hits        53065    53063       -2     
- Misses      21041    21043       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant