Rework Docker release workflow ordering#2079
Draft
asmogo wants to merge 6 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
==========================================
+ Coverage 71.08% 71.27% +0.19%
==========================================
Files 356 356
Lines 72678 73170 +492
==========================================
+ Hits 51664 52153 +489
- Misses 21014 21017 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
asmogo
commented
Jun 17, 2026
Comment on lines
+26
to
+28
| - name: Install Nix | ||
| uses: DeterminateSystems/nix-installer-action@v14 | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
why is this line missing in current main ? seems like we don't need to install nix on these jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)