ci: add redis cache testing to nix environment#2024
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
==========================================
- Coverage 71.60% 71.59% -0.02%
==========================================
Files 356 356
Lines 74106 74106
==========================================
- Hits 53061 53053 -8
- Misses 21045 21053 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fe8eb63 to
4a6643c
Compare
|
All the CI checks are failing with No space left on device (os error 28). The GitHub Actions runner disk is full. |
9c92dab to
7fec27b
Compare
cdk-bot
left a comment
There was a problem hiding this comment.
Verified findings approved for disclosure:
- Register the Redis cleanup trap before starting Redis (medium) - If cluster startup fails,
just test-redisleaves the previously-started single-node Redis process running, causing local resource leaks and possible port conflicts or stale state on subsequent test runs.
a7062e4 to
9e22e37
Compare
|
The new test-redis recipe starts Redis, but the cargo test -p cdk-axum --features redis --lib suite does not currently exercise a live Redis cache. The full test list only includes config parsing/default tests plus unrelated handler/router/ws tests; nothing instantiates HttpCache::from_config with Backend::Redis or calls set/get through the Redis backend. That means this CI job can pass even if single-node or cluster Redis cache operations are broken. |
4c942ea to
31ae640
Compare
cdk-bot
left a comment
There was a problem hiding this comment.
Verified findings approved for disclosure:
- Redis CI recipe runs the same lib test suite twice (low) - The Redis CI recipe repeats the same cdk-axum lib test suite, wasting CI time on the self-hosted runner without adding coverage.
Description
Resolves #1978
Notes to the reviewers
start-redis-singleandstop-redis-singleNix scripts for standalone Redis testing (port 6379).start-redis-clusterandstop-redis-clusterNix scripts for 3-node Redis testing (ports 7001-7003).redisShellHookto export the exact environment variables expected bycdk-axumfor both topologies.test-redisrecipe injustfilethat spins up both Nix-managed environments and verifiescdk-axumwith theredisfeature enabled.redis-testsCI job in GitHub Actions that runs these tests in theregtestenvironment, mirroring the existingpostgres-testsjob.Suggested CHANGELOG Updates
ADDED
redis-tests) to validate the Redis cache backend incdk-axum.Checklist
just quick-checkbefore committing