Wallet UX for on-chain (Ark) boards + Proof-of-Reserves card#539
Closed
mvuk wants to merge 5 commits into
Closed
Conversation
Signed-off-by: Matthew Vuk <matthew@second.tech>
…shness, verify-independently) NOTE: integration fixes pending — switch freshness tip from Mutinynet to mainnet esplora; replace placeholder public verifier repo URL with local-only verify instructions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Matthew Vuk <matthew@second.tech>
…erify (no public repo link) Signed-off-by: Matthew Vuk <matthew@second.tech>
Signed-off-by: Matthew Vuk <matthew@second.tech>
…melts - checkOnchainAndMint: poll the quote WITHOUT the global mutex (the background checker polls every pending on-chain quote; contending on the single global lock made operations time out as "Please try again."). Take the lock only for the actual mint, and re-check under it to avoid double-minting. - ui store: steal a stale global mutex lock after 30s so a stuck lock self-heals. - confirmations: default 6 for mint (board maturation), keep 1 for melt (mint's own tx settles fast); prefer exact-unit method, fall back to any onchain method. - PoR card: render "unknown" instead of a confident "0 sat"/self-reported freshness when reserve total or an independent chain tip is missing. - history: show "Confirming…" for amountless pending receives instead of "+0". - pay dialog: surface the fee up-front; don't eagerly compute fee_paid for async on-chain melts (would overstate the fee from a still-pending quote). - create-invoice: drop the broken on-chain "reusable address" path (Create Address always mints a new one, so it showed two QRs for one deposit). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Matthew Vuk <matthew@second.tech>
mvuk
force-pushed
the
onchain-board-and-por-ui
branch
from
3ff3083 to
eed8a30
Compare
Author
|
Superseded by #540 — recreated from a clean branch to drop force-push history. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet UX for on-chain (Ark) boards + Proof-of-Reserves card
What's included
via mempool.space), "verify independently" — renders "unknown" rather than a
confident "0 sat"/self-reported freshness when reserve total or an independent tip is
missing. PoR is framed as a lower bound.
eagerly compute
fee_paidfor async on-chain melts (which would overstate the fee).of a misleading "+0"; default 6 confirmations for boards (maturation depth).
background checker was contending → "Please try again." timeouts); lock only for the
mint, with a re-check to avoid double-minting; steal a stale global mutex lock after 30s.
Notes
Signed-off-by.advertising an on-chain method.
🤖 Generated with Claude Code