Skip to content

fix(annotation): use correct len for original annotation #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gutmensch wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(annotation): use correct len for original annotation #1101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pkg/kapp/diff/resource_with_history.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package diff

import (
"fmt"
"k8s.io/apimachinery/pkg/api/validation"
"os"

ctlres "carvel.dev/kapp/pkg/kapp/resources"
Expand Down Expand Up @@ -97,14 +98,10 @@ func (r ResourceWithHistory) RecordLastAppliedResource(appliedChange Change) (ct
},
}

const annValMaxLen = 262144

// kapp deploy should work without adding disable annotation when annotation value max length exceed
// (https://github.com/carvel-dev/kapp/issues/410)
for _, annVal := range annsMod.KVs {
if len(annVal) > annValMaxLen {
return nil, false, nil
}
if err = validation.ValidateAnnotationsSize(annsMod.KVs); err != nil {
return nil, false, nil
}

resultRes := r.resource.DeepCopy()
Expand Down
Loading