Fix crash when the key is not found.#37
Open
skorokithakis wants to merge 2 commits intocartwheelweb:masterfrom
Open
Fix crash when the key is not found.#37skorokithakis wants to merge 2 commits intocartwheelweb:masterfrom
skorokithakis wants to merge 2 commits intocartwheelweb:masterfrom
Conversation
Author
|
Okay, the previous fix didn't work (it seems the key exists and is None), so I've fixed it properly and tested it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the key is not found, .get() will return None and the program will crash. This way, it doesn't.