Added NodeMCU board support.#173
Open
flsg wants to merge 2 commits intocarlosperate:masterfrom
Open
Conversation
Owner
|
Hi, Thank you very much for the submission, it'd be great to add this to the Ardublockly repository, but this PR contain a lot of changes not related to the required changes (and a lot of formatting changes). It'd be great if you update this PR or create a new one with just the changes needed for this additional board support. It'd be even better if you could also separate the fixes to the Wemos support into a different PR, as that would make it easier for me to review and test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds the following features:
It fixes the following issues: