Skip to content

docs: clarify PR design review and approval requirements#22048

Merged
heloiselui merged 7 commits intocarbon-design-system:mainfrom
heloiselui:21937-improve-pr-review-docs
Apr 21, 2026
Merged

docs: clarify PR design review and approval requirements#22048
heloiselui merged 7 commits intocarbon-design-system:mainfrom
heloiselui:21937-improve-pr-review-docs

Conversation

@heloiselui
Copy link
Copy Markdown
Contributor

@heloiselui heloiselui commented Apr 16, 2026

Closes #21937

Clarifies the PR review process when design review is required, including labels, approvals, and merge readiness.

Changelog

New

  • Added guidance for when a PR needs design review (status: visual review)

Changed

  • Updated PR docs to define approval requirements:
    • Visual/UI changes: 2 developer approvals + 1 design approval
    • Non-visual changes: 2 developer approvals
  • Clarified when to add/remove status: visual review and when to add status: ready to merge
  • Added a note to avoid merging before required approvals are complete
  • Updated TOC

Removed

  • None

Testing / Reviewing

  • Review the updated sections

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • [ ] Wrote passing tests that cover this change
  • [ ] Addressed any impact on accessibility (a11y)
  • [ ] Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 16, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a66e5aa
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69e7326a48408d0008d7084e
😎 Deploy Preview https://deploy-preview-22048--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 16, 2026

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a66e5aa
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69e7326a075fcb00081aa438
😎 Deploy Preview https://deploy-preview-22048--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (59380c1) to head (a66e5aa).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22048      +/-   ##
==========================================
- Coverage   95.04%   95.01%   -0.03%     
==========================================
  Files         538      538              
  Lines       44982    44982              
  Branches     6514     6459      -55     
==========================================
- Hits        42752    42740      -12     
- Misses       2101     2113      +12     
  Partials      129      129              
Flag Coverage Δ
main-packages 89.03% <ø> (ø)
web-components 97.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread docs/guides/reviewing-pull-requests.md Outdated
Comment thread docs/guides/reviewing-pull-requests.md Outdated
Comment thread docs/guides/reviewing-pull-requests.md
heloiselui and others added 3 commits April 20, 2026 07:46
Co-authored-by: Adam Alston <aalston9@gmail.com>
Co-authored-by: Adam Alston <aalston9@gmail.com>
Co-authored-by: Adam Alston <aalston9@gmail.com>
Comment thread docs/guides/reviewing-pull-requests.md Outdated
Copy link
Copy Markdown
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, following the link update from previous review.

Co-authored-by: Adam Alston <aalston9@gmail.com>
@heloiselui heloiselui added this pull request to the merge queue Apr 21, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 21, 2026
@heloiselui heloiselui enabled auto-merge April 21, 2026 08:34
@heloiselui heloiselui added this pull request to the merge queue Apr 21, 2026
Merged via the queue into carbon-design-system:main with commit f28c7f5 Apr 21, 2026
39 checks passed
@heloiselui heloiselui deleted the 21937-improve-pr-review-docs branch April 21, 2026 08:53
@carbon-automation
Copy link
Copy Markdown
Contributor

Hey there! v11.106.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Improve PR Review Guidelines (Design + Dev Approval Process)

3 participants