Skip to content

fix: preserve DatePicker tab flow in readOnly mode#22010

Merged
maradwan26 merged 1 commit intocarbon-design-system:mainfrom
adamalston:21152-date-picker
Apr 20, 2026
Merged

fix: preserve DatePicker tab flow in readOnly mode#22010
maradwan26 merged 1 commit intocarbon-design-system:mainfrom
adamalston:21152-date-picker

Conversation

@adamalston
Copy link
Copy Markdown
Contributor

Closes #21152

Preserve DatePicker tab flow in readOnly mode.

Changelog

Changed

  • Preserve DatePicker tab flow in readOnly mode.

Testing / Reviewing

yarn test packages/react/src/components/DatePicker/DatePicker-test.js

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2026

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 84869df
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69dbede19c68bd0008e56421
😎 Deploy Preview https://deploy-preview-22010--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 84869df
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69dbede1e723eb000875556d
😎 Deploy Preview https://deploy-preview-22010--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.92%. Comparing base (597001a) to head (84869df).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22010      +/-   ##
==========================================
+ Coverage   94.90%   94.92%   +0.02%     
==========================================
  Files         541      541              
  Lines       45253    45254       +1     
  Branches     6359     6332      -27     
==========================================
+ Hits        42949    42959      +10     
+ Misses       2172     2163       -9     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.15% <100.00%> (-0.02%) ⬇️
web-components 97.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Contributor

@maradwan26 maradwan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maradwan26 maradwan26 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into carbon-design-system:main with commit b49f0eb Apr 20, 2026
55 checks passed
@adamalston adamalston deleted the 21152-date-picker branch April 20, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Datepicker] Tab navigation in Datepicker in readOnly mode renders an unwanted blank dialog

3 participants