Skip to content

refactor: hoist Slider props and remove dead refs#22001

Merged
tay1orjones merged 1 commit intocarbon-design-system:mainfrom
adamalston:n/a-slider-props
Apr 27, 2026
Merged

refactor: hoist Slider props and remove dead refs#22001
tay1orjones merged 1 commit intocarbon-design-system:mainfrom
adamalston:n/a-slider-props

Conversation

@adamalston
Copy link
Copy Markdown
Contributor

@adamalston adamalston commented Apr 11, 2026

No issue.

Hoisted Slider props and remove dead refs.

Changelog

Changed

  • Hoisted Slider props.
  • Replaced all props.<property> references with direct variables which should improve consistency.

Removed

  • Removed dead Slider refs like propsRef and trackRef which became obsolete as the refactor progressed.
  • Removed an unnecessary re-read of props in calcDiscreteValueAndPercent.

Testing / Reviewing

Existing tests should cover these changes.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 11, 2026

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 78d8ec2
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69da6f5826e1da0008143aa5
😎 Deploy Preview https://deploy-preview-22001--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 11, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 78d8ec2
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69da6f5883688c00089f43b3
😎 Deploy Preview https://deploy-preview-22001--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.93%. Comparing base (597001a) to head (78d8ec2).
⚠️ Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
packages/react/src/components/Slider/Slider.tsx 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22001      +/-   ##
==========================================
+ Coverage   94.90%   94.93%   +0.02%     
==========================================
  Files         541      541              
  Lines       45253    45234      -19     
  Branches     6359     6382      +23     
==========================================
- Hits        42949    42941       -8     
+ Misses       2172     2161      -11     
  Partials      132      132              
Flag Coverage Δ
main-packages 89.15% <95.65%> (-0.02%) ⬇️
web-components 97.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tay1orjones tay1orjones added this pull request to the merge queue Apr 27, 2026
Merged via the queue into carbon-design-system:main with commit 772779d Apr 27, 2026
55 checks passed
@adamalston adamalston deleted the n/a-slider-props branch April 27, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants