refactor: hoist Slider props and remove dead refs#22001
Merged
tay1orjones merged 1 commit intocarbon-design-system:mainfrom Apr 27, 2026
Merged
refactor: hoist Slider props and remove dead refs#22001tay1orjones merged 1 commit intocarbon-design-system:mainfrom
tay1orjones merged 1 commit intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22001 +/- ##
==========================================
+ Coverage 94.90% 94.93% +0.02%
==========================================
Files 541 541
Lines 45253 45234 -19
Branches 6359 6382 +23
==========================================
- Hits 42949 42941 -8
+ Misses 2172 2161 -11
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tay1orjones
approved these changes
Apr 27, 2026
Merged
via the queue into
carbon-design-system:main
with commit Apr 27, 2026
772779d
55 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Hoisted Slider props and remove dead refs.
Changelog
Changed
props.<property>references with direct variables which should improve consistency.Removed
Sliderrefs likepropsRefandtrackRefwhich became obsolete as the refactor progressed.calcDiscreteValueAndPercent.Testing / Reviewing
Existing tests should cover these changes.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide