refactor: use mock_timeit utility in categorical timeit test - #1219
Open
ovodela wants to merge 1 commit into
Open
refactor: use mock_timeit utility in categorical timeit test#1219ovodela wants to merge 1 commit into
ovodela wants to merge 1 commit into
Conversation
Replace the manual time.time patch with a hardcoded float array with the shared test_utils.mock_timeit() context manager, consistent with other tests in the same file (lines 940, 1004) and across the codebase. Also removes the now-unused unittest.mock.patch import. Closes capitalone#806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.timepatch (hardcoded float array with.pop()) intest_timeit_profilewith the sharedtest_utils.mock_timeit()context managerfrom unittest.mock import patchimportTest plan
test_timeit_profilepasses with the new mockCloses #806