Support for token standard V2 (CIP-112) - #2267
Open
phillip-cashen wants to merge 6 commits into
Open
Conversation
Signed-off-by: Phillip Olesen [Cashen] <phillip@cashen.cc>
Signed-off-by: Phillip Olesen [Cashen] <phillip@cashen.cc>
Signed-off-by: Phillip Olesen [Cashen] <phillip@cashen.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello again Wallet Team 🥳
i have taken a stab at implementing CIP-112 AKA token standard V2 all the way throughout you stack, using me lessons from last time and any standard that you are adopting in your code.
Hopefully this is not to big 😢 i know it is many lines changes (but that seems unavoidable which such a huge stack), let me know if you prefer if i split this is into several smaller PRs instead, a good split suggestion in my eyes could be:
also if me submitting unprovoked PR's like this is more disturbing then helping do let me know, i'm all for collaborating in any format that suits you well.