feat(core-splice-codegen,example-test-token-v1-registry): create new core package, move test token - #2249
Open
mateuszpiatkowski-da wants to merge 5 commits into
Open
feat(core-splice-codegen,example-test-token-v1-registry): create new core package, move test token#2249mateuszpiatkowski-da wants to merge 5 commits into
mateuszpiatkowski-da wants to merge 5 commits into
Conversation
mateuszpiatkowski-da
force-pushed
the
mateuszpiatkowski-da/core-otc-trade
branch
from
August 7, 2026 14:04
b7e6a91 to
0cb8d54
Compare
mateuszpiatkowski-da
changed the title
mateuszpiatkowski-da
force-pushed
the
mateuszpiatkowski-da/core-otc-trade
branch
2 times, most recently
from
August 10, 2026 10:50
ad88237 to
1528951
Compare
…core package, move test token there Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
mateuszpiatkowski-da
force-pushed
the
mateuszpiatkowski-da/core-otc-trade
branch
from
August 10, 2026 15:13
588d518 to
59be9f0
Compare
| }) | ||
| } | ||
|
|
||
| Promise.all( |
Contributor
There was a problem hiding this comment.
I think we need await here
| "generate:test-token": "tsx ./scripts/src/generate-test-token.ts", | ||
| "generate:all": "yarn generate:dapp && yarn generate:dapp-remote && yarn generate:user && yarn generate:signing && yarn generate:tokenstandard && yarn generate:test-token && yarn run prettier . --write > /dev/null 2>&1", | ||
| "generate:codegen": "tsx ./scripts/src/generate-daml-codegen.ts", | ||
| "generate:all": "yarn generate:dapp && yarn generate:dapp-remote && yarn generate:user && yarn generate:signing && yarn generate:tokenstandard && yarn generate:codegen && yarn run prettier . --write > /dev/null 2>&1", |
Contributor
There was a problem hiding this comment.
I didn't check if it's changed further in stack, but remember that we replaced yarn with pnpm
|
|
||
| ## Exports | ||
|
|
||
| Top-level exports (from `src/index.ts`): |
Contributor
There was a problem hiding this comment.
I would go through this readme and check which sections actually provide value to reader. For example here the same info can be derived by quick look at index. You could either add some descriptions what is TestToken and what is OTCTrade, or just omit it. Build outputs section also provides exactly the same info that dedicated property in package.json - I would skip that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mateusz Piątkowski mateusz.piatkowski@digitalasset.com
Stack created with GitHub Stacks CLI • Give Feedback 💬