Validate Snippet page declarations - #1325
Draft
danielporterda wants to merge 1 commit into
Draft
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Composes snippet-page validation against the separately validated condition page. It parses
<Snippet>, validates basic attributes, resolves source/path attributes, applies repository/path safety and local-preview policy, maps condition context, checks candidate identity, and returns only fully validated snippets plus diagnostics.It does not combine condition and snippet diagnostics into a whole-page entry point, add a CLI, resolve remote content, or compile MDX.
Why
Snippet declaration composition is independently reviewable from conditional composition and from the public validator command.
Validation
python -m pytest tests/test_snippet_page_validation.py tests/test_condition_page_validation.py tests/test_candidate_condition_diagnostics.py tests/test_local_snippet_source_remediation.py(12 passed)python -m ruff check scripts/snippets/model.py scripts/snippets/page_validation.py tests/test_snippet_page_validation.pypython -m mypy scripts/snippets/model.py scripts/snippets/page_validation.pygit diff --check