Code IfVersion attribute diagnostics - #1319
Draft
danielporterda wants to merge 1 commit into
Draft
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Maps
<IfVersion>attribute failures to stable diagnostics:SNIP020for unknown attributes,SNIP021for an invalid repository URL,SNIP022for an unregistered repository, andSNIP023for an invalid PR expression.This PR assigns codes only and does not change condition validation.
Why
Condition-attribute diagnostics are separate from conditional structure and candidate-identity diagnostics.
Validation
python -m pytest tests/test_if_version_attribute_diagnostics.py tests/test_if_version_attribute_validation.py(11 passed)python -m ruff check scripts/snippets/diagnostics.py tests/test_if_version_attribute_diagnostics.pypython -m mypy scripts/snippets/diagnostics.pygit diff --check