Map snippets to IfVersion contexts - #1312
Draft
danielporterda wants to merge 1 commit into
Draft
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Associates each parsed
<Snippet>tag with its innermost enclosing validated<IfVersion>condition.Unconditional snippets map to no condition; snippets in either the primary or fallback branch map to the same enclosing condition; nested snippets map to the innermost condition. This layer assumes structural and condition-attribute validation have already succeeded and does not compare source identity.
Why
Determining context is separate from deciding whether a candidate PR source matches that context.
Validation
python -m pytest tests/test_snippet_condition_context.py tests/test_if_version_structure_validation.py tests/test_if_version_attribute_validation.py(18 passed)python -m ruff check scripts/snippets/model.py scripts/snippets/semantics.py tests/test_snippet_condition_context.pypython -m mypy scripts/snippets/model.py scripts/snippets/semantics.pygit diff --check