Validate resolved snippet source safety - #1309
Draft
danielporterda wants to merge 1 commit into
Draft
Conversation
Signed-off-by: danielporterda <daniel.porter@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Applies repository allowlisting and relative-path safety to a resolved snippet source.
It composes the independently introduced membership and path predicates and returns span-anchored validation issues. It does not apply the preview-only local-ref policy or candidate/condition identity.
Why
Source safety is separate from source/path attribute shape and from lifecycle policy.
Validation
python -m pytest tests/test_snippet_source_safety_validation.py tests/test_snippet_source_path_validation.py tests/test_snippet_repository_membership.py(14 passed)python -m ruff check scripts/snippets/model.py scripts/snippets/validation.py tests/test_snippet_source_safety_validation.pypython -m mypy scripts/snippets/model.py scripts/snippets/validation.pygit diff --check