Skip to content

[WIP] Switch the SftpServer to use SftpSession - #5119

Draft
ricab wants to merge 2 commits into
sftp-session-apifrom
sftp-server-switch
Draft

[WIP] Switch the SftpServer to use SftpSession#5119
ricab wants to merge 2 commits into
sftp-session-apifrom
sftp-server-switch

[sftp] Improve logic for open-flags

5dd158d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 30, 2026 in 0s

73.04% (-0.29%) compared to 264877c

View this Pull Request on Codecov

73.04% (-0.29%) compared to 264877c

Details

Codecov Report

❌ Patch coverage is 42.93478% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.04%. Comparing base (264877c) to head (5dd158d).

Files with missing lines Patch % Lines
src/ssh/plain_sftp_message.cpp 0.00% 74 Missing ⚠️
src/ssh/plain_sftp_session.cpp 35.00% 26 Missing ⚠️
include/multipass/sshfs_mount/sftp_message.h 0.00% 2 Missing ⚠️
src/ssh/libssh_wrapper.cpp 0.00% 2 Missing ⚠️
src/sshfs_mount/sftp_server.cpp 97.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            vsock    #5030      +/-   ##
==========================================
- Coverage   73.33%   73.04%   -0.29%     
==========================================
  Files         334      336       +2     
  Lines       17978    18092     +114     
==========================================
+ Hits        13183    13213      +30     
- Misses       4795     4879      +84

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov