pam/tests: Avoid snapshotting a half-rendered QR matrix#1625
Draft
adombeck wants to merge 1 commit into
Draft
Conversation
TestCLIAuthenticate/Authenticate_user_with_qr_code_in_a_TTY intermittently captured an extra terminal frame: a QR screen with a partially-drawn matrix appeared between the auth-method-selection frame and the first complete QR frame, failing the golden comparison. The QR view (label, QR matrix, URL, Code) is rendered as a single string, but in a TTY the large ToString() matrix exceeds the 4096-byte PTY read buffer and arrives over several reads. WaitFor polls the growing buffer every 50ms, so a poll for the "Scan the qrcode" label (top of the view) can match while later reads carrying "Code:" (bottom) are still pending, snapshotting a half-drawn matrix. Whether this intermediate frame coincides with a poll boundary is timing-dependent, hence the flake; the non-TTY variants use the smaller ToSmallString() matrix that fits in one read, so they never hit it. Discard the intermediate "Scan the qrcode" frame and keep only the "Code:" frame, which is a cumulative-screen superset capturing the same fully-rendered view. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
+ Coverage 84.24% 87.99% +3.75%
==========================================
Files 21 99 +78
Lines 1168 6832 +5664
Branches 0 111 +111
==========================================
+ Hits 984 6012 +5028
- Misses 184 764 +580
- Partials 0 56 +56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCLIAuthenticate/Authenticate_user_with_qr_code_in_a_TTY intermittently captured an extra terminal frame: a QR screen with a partially-drawn matrix appeared between the auth-method-selection frame and the first complete QR frame, failing the golden comparison.
The QR view (label, QR matrix, URL, Code) is rendered as a single string, but in a TTY the large ToString() matrix exceeds the 4096-byte PTY read buffer and arrives over several reads. WaitFor polls the growing buffer every 50ms, so a poll for the "Scan the qrcode" label (top of the view) can match while later reads carrying "Code:" (bottom) are still pending, snapshotting a half-drawn matrix. Whether this intermediate frame coincides with a poll boundary is timing-dependent, hence the flake; the non-TTY variants use the smaller ToSmallString() matrix that fits in one read, so they never hit it.
Discard the intermediate "Scan the qrcode" frame and keep only the "Code:" frame, which is a cumulative-screen superset capturing the same fully-rendered view.