Skip to content

fromPgn: implement DECIMAL field type (fixes PGN 129808 DSC MMSI decode) #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fakehec wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fromPgn: implement DECIMAL field type (fixes PGN 129808 DSC MMSI decode) #452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94fbae1
fromPgn: implement DECIMAL field type (PGN 129808 DSC MMSI addresses)
fakehec Jul 16, 2026
abfeed4
fromPgn: harden DECIMAL field decoding
fakehec Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/fromPgn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,6 +1267,22 @@ function readValue(
): [any, Field | undefined] {
if (field.FieldType == 'VARIABLE') {
return readVariableLengthField(definition, options, pgn, field, bs)
} else if (field.FieldType === 'DECIMAL') {
// DECIMAL: each byte holds two decimal digits (00-99). Emit as a digit
// string to preserve leading zeros (e.g. coast-station identities).
// All-0xFF (or any byte > 99) => not available. Used by PGN 129808 (DSC).
const nbytes = Math.floor(
(bitLength === undefined ? (field.BitLength as number) : bitLength) / 8
)
let s = ''
let allFF = true
for (let i = 0; i < nbytes; i++) {
const b = bs.readUint8()
if (b !== 0xff) allFF = false
if (b > 99) allFF = true
s += String(b).padStart(2, '0')
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
return allFF ? [null, undefined] : [s, undefined]
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
} else {
let value
if (bitLength === undefined) {
Expand Down