Show credentials inside Credential where they need to be - #1447
Closed
adamnovak wants to merge 1 commit into
Closed
Conversation
This should fix calypr#1446.
Contributor
|
Thanks for spotting this. I have pulled in your commit from this branch into #1450 which aims to address your other issues as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the example
RPCClientconfiguration section to have theUserandPasswordfields in the right place.Motivation and Context
This should fix #1446. In #1150 the
UserandPasswordfields ofRPCClientwere moved inside a field namedCredential, but the documentation's example configuration still shows them at their old location.How Has This Been Tested?
I made my configuration look like this and started Funnel v0.11.14 and the server came up instead of rejecting the configuration.
Types of Changes
Checklist
I don't think the documentation is under test, right? Otherwise this would have been caught already.
I wrote this in the Github web editor, and I'm not set up with a real dev environment to run the test suite.