Skip to content

Show credentials inside Credential where they need to be - #1447

Closed
adamnovak wants to merge 1 commit into
calypr:developfrom
adamnovak:patch-1
Closed

Show credentials inside Credential where they need to be#1447
adamnovak wants to merge 1 commit into
calypr:developfrom
adamnovak:patch-1

Conversation

@adamnovak

Copy link
Copy Markdown
Contributor

Description

This updates the example RPCClient configuration section to have the User and Password fields in the right place.

Motivation and Context

This should fix #1446. In #1150 the User and Password fields of RPCClient were moved inside a field named Credential, but the documentation's example configuration still shows them at their old location.

How Has This Been Tested?

I made my configuration look like this and started Funnel v0.11.14 and the server came up instead of rejecting the configuration.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly (link here).
  • I have tested that this feature locally.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Reviewer has tested this feature locally

I don't think the documentation is under test, right? Otherwise this would have been caught already.

I wrote this in the Github web editor, and I'm not set up with a real dev environment to run the test suite.

@matthewpeterkort

Copy link
Copy Markdown
Contributor

Thanks for spotting this. I have pulled in your commit from this branch into #1450 which aims to address your other issues as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Credentials in RPCClient need to be inside a Credential field now, but the documentation

2 participants