Skip to content

perf: don't block onload on Bases registration #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tgrosinger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: don't block onload on Bases registration #2187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions src/bases/registration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,24 +278,7 @@ export async function registerBasesTaskList(plugin: TaskNotesPlugin): Promise<bo
}
};

// Try immediate registration
if (await attemptRegistration()) {
return true;
}

// If that fails, try a few more times with short delays
for (let i = 0; i < 5; i++) {
await new Promise((r) => window.setTimeout(r, 200));
if (await attemptRegistration()) {
return true;
}
}

logger.warn("Failed to register views after multiple attempts", {
category: "configuration",
operation: "register-views",
});
return false;
return attemptRegistration();
}

/**
Expand Down
4 changes: 3 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,9 @@ export default class TaskNotesPlugin extends Plugin {
this.migrationPromise = this.performEarlyMigrationCheck();

initializeCalendarProviders(this);
await registerBasesIntegration(this);
// Not awaited: if Bases has not loaded yet this schedules a retry timer,
// and initializeAfterLayoutReady attempts registration again.
void registerBasesIntegration(this);

// Defer expensive initialization until layout is ready
this.app.workspace.onLayoutReady(() => {
Expand Down
Loading