fix(channels): keep empty topic_id distinct from missing topic - #4723
Open
richardmilles wants to merge 1 commit into
Open
fix(channels): keep empty topic_id distinct from missing topic#4723richardmilles wants to merge 1 commit into
richardmilles wants to merge 1 commit into
Conversation
|
|
github-actions
Bot
added
area:backend
richardmilles
force-pushed
the
fix/channel-store-empty-topic-id
branch
2 times, most recently
from
August 7, 2026 09:15
e8b36ac to
e8dc576
Compare
Empty topic_id no longer collapses onto the base conversation mapping.
richardmilles
force-pushed
the
fix/channel-store-empty-topic-id
branch
from
August 7, 2026 09:18
e8dc576 to
a9d9e63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChannelStore._key() treated topic_id="" like missing, so empty topics could overwrite or delete the base conversation mapping. It now matches remove() with is not None and has a regression test.