refactor(frontend): extract SHOWCASE_ROUTE_PREFIX constant - #4712
Draft
icn5381 wants to merge 1 commit into
Draft
Conversation
Replace the two hardcoded `/showcase/` literals (the URL builder in static-demo.ts and the mock-mode path check in use-thread-chat.ts) with a shared `SHOWCASE_ROUTE_PREFIX` constant exported from static-demo.ts, so the route dependency is explicit and grep-able rather than scattered. Suggested in the bytedance#4635 review. References bytedance#4635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the two hardcoded
/showcase/literals (the URL builder in static-demo.ts and the mock-mode path check in use-thread-chat.ts) with a sharedSHOWCASE_ROUTE_PREFIXconstant exported from static-demo.ts, so the route dependency is explicit and grep-able rather than scattered.Suggested in the #4635 review.
References #4635
Fixes #
Why
What changed
Surface area
frontend/backend/applanggraph.json, or prompt changedocker/or sandboxed executionskills/backend/pyproject.tomlorfrontend/package.json(say what it buys us)Screenshots / Recording
Bug fix verification
Validation
AI assistance
Tool(s) used:
How you used it: