test(skillscan): pin tuple-unpacking instance-client false negative - #4708
Open
icn5381 wants to merge 1 commit into
Open
test(skillscan): pin tuple-unpacking instance-client false negative#4708icn5381 wants to merge 1 commit into
icn5381 wants to merge 1 commit into
Conversation
Add tuple-unpacking assignment (`s, other = requests.Session(), 1`) to the declared false-negative parametrization. The multi-target binding is outside the simple-name evidence chain the one-level scanner follows, so the scanner stays silent while the runtime still calls the client. Suggested in the bytedance#4644 review; also a case bytedance#4296 enumerates. References bytedance#4644
github-actions
Bot
added
risk:medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #4644
Why
PR #4644 documented the instance-client false negatives the narrowed SkillScan model deliberately gives up (issue #4296). Its reviewer noted tuple-unpacking assignment (
s, other = requests.Session(), 1) is another false negative in the same class but was left out to keep that PR's scope. This pins it alongside the rest so any future model-widening or -narrowing has to touch this test rather than change behavior silently.What changed
Add one parametrized case to
test_python_declared_false_negatives_stay_unreportedcovering tuple-unpacking binding of arequests.Sessionhandle. Pure test addition; zero runtime change.Surface area
Validation
cd backend && PYTHONPATH=. uv run pytest tests/test_skillscan_native.py -q→ 141 passedcd backend && make lint && make format→ cleanAI assistance