EvaluteRTE: Correctly report AbortOnValue aborts with negative abort codes - #500
Open
t-b wants to merge 3 commits into
Open
EvaluteRTE: Correctly report AbortOnValue aborts with negative abort codes#500t-b wants to merge 3 commits into
t-b wants to merge 3 commits into
Conversation
Garados007
requested changes
Jul 24, 2025
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
2 times, most recently
from
August 31, 2025 21:24
ebcc83c to
5d3d41a
Compare
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
from
September 1, 2025 14:51
5d3d41a to
090eb74
Compare
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
from
January 23, 2026 17:15
090eb74 to
4594005
Compare
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
from
May 19, 2026 19:36
1415bd3 to
d475ec7
Compare
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
from
July 24, 2026 16:32
4f0d294 to
e32b485
Compare
…codes We need to assume that all error codes not being -1, -2, -3, -4 are from AbortOnValue as we can't differentiate them. This now correctly reports AbortOnValue aborts with negative abort codes. Broken since a7ab54c (More detailed RTE error message, 2017-03-07). It did not help that the Igor Pro documentation is also wrong in this regard.
The parameter is gone since 2f80d1a (Refactor TAP to use test result waves, 2022-12-02).
The old version does not work with the updated docker-utils CI image. $ pre-commit run --all-files --show-diff-on-failure [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version. Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this. if it does not -- consider reporting an issue to that repo. [INFO] Initializing environment for https://github.com/sirosen/texthooks. [INFO] Initializing environment for https://github.com/fsfe/reuse-tool. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/sirosen/texthooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/fsfe/reuse-tool. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... check for added large files..............................................Passed fix utf-8 byte order marker..............................................Passed check for case conflicts.................................................Passed check that executables have shebangs.....................................Passed check json...........................................(no files to check)Skipped check for merge conflicts................................................Passed check that scripts with shebangs are executable..........................Passed check for broken symlinks............................(no files to check)Skipped check yaml...............................................................Passed detect destroyed symlinks................................................Passed fix end of files.........................................................Passed mixed line ending........................................................Passed trim trailing whitespace.................................................Passed Forbid the use of unicode BiDi control characters........................Passed reuse....................................................................Failed - hook id: reuse - exit code: 1 Traceback (most recent call last): File "/builds/mirror/igortest/.cache/pre-commit/repoaq9hl26l/py_env-python3/bin/reuse", line 5, in <module> from reuse._main import main File "/builds/mirror/igortest/.cache/pre-commit/repoaq9hl26l/py_env-python3/lib/python3.13/site-packages/reuse/__init__.py", line 15, in <module> from pkg_resources import DistributionNotFound, get_distribution ModuleNotFoundError: No module named 'pkg_resources'
t-b
force-pushed
the
bugfix/ignored-negative-abort-on-value-values
branch
from
July 24, 2026 16:43
e32b485 to
144261c
Compare
Member
Author
|
The JUNIT output for AbortedTests.ipf JU_UnitTests_2026-07-24_18-57-07.xml has This needs fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to assume that all error codes not being -1, -2, -3, -4 are from AbortOnValue as we can't differentiate them. This now correctly reports AbortOnValue aborts with negative abort codes.
Broken since a7ab54c (More detailed RTE error message, 2017-03-07). It did not help that the Igor Pro documentation is also wrong in this regard.