Skip to content

Scroll to selected item on filter invalidation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
potatopplking wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Scroll to selected item on filter invalidation #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions cutelog/logger_tab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
from functools import partial

from qtpy.QtCore import (QAbstractItemModel, QAbstractTableModel, QEvent, QItemSelectionModel,
QModelIndex, QSize, QSortFilterProxyModel, Qt)
QModelIndex, QSize, QSortFilterProxyModel, QTimer, Qt)
from qtpy.QtGui import QBrush, QColor, QFont
from qtpy.QtWidgets import (QCheckBox, QHBoxLayout, QMenu, QShortcut, QStyle,
QTableWidgetItem, QWidget)
QTableWidgetItem, QWidget, QAbstractItemView)

from .config import CONFIG, Exc_Indication
from .level_edit_dialog import LevelEditDialog
Expand Down Expand Up @@ -1040,7 +1040,15 @@ def invalidate_filter(self, resize_rows=True):
# resizeRowsToContents is very slow, so it's best to try to do it only when necessary
if resize_rows and (self.extra_mode or self.word_wrap):
self.loggerTable.resizeRowsToContents()
if self.autoscroll:
selected = self.loggerTable.selectionModel().currentIndex()
if selected.row() > 0: # -1 if nothing selected
# scrollTo needs to be called twice, once immediately
# and once with some minimal delay. Not sure why
def scroll_to_selected():
self.loggerTable.scrollTo(selected, QAbstractItemView.PositionAtCenter)
scroll_to_selected()
QTimer.singleShot(0, scroll_to_selected)
elif self.autoscroll:
self.loggerTable.scrollToBottom()

def onScroll(self, pos):
Expand Down